Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange states #32

Open
lonagi opened this issue Sep 17, 2021 · 3 comments
Open

Strange states #32

lonagi opened this issue Sep 17, 2021 · 3 comments

Comments

@lonagi
Copy link

lonagi commented Sep 17, 2021

Why do I need the showClose state (for X) if I want just to close modal using escape or click to bg?

image

wut ?

image

@lonagi
Copy link
Author

lonagi commented Sep 19, 2021

Sorry for closing.

What's solution for this issue. Just delete if states

@craigharman
Copy link
Member

craigharman commented Sep 20, 2021

showClose currently sets whether the user can close the modal window at all. Setting to false assumes you don't want to give the user the ability to close the window at all - and that you would do it programmatically.
I'd suggest 2 variables one for display and one for user control, did you want to send a PR?

@lonagi
Copy link
Author

lonagi commented Sep 20, 2021

showClose currently sets whether the user can close the modal window at all. Setting to false assumes you don't want to give the user the ability to close the window at all - and that you would do it programmatically.
I'd suggest 2 variables one for display and one for user control, did you want to send a PR?

Yes, your suggestion is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants