Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List view #16

Closed
justinpituch opened this issue Jun 17, 2015 · 30 comments
Closed

List view #16

justinpituch opened this issue Jun 17, 2015 · 30 comments

Comments

@justinpituch
Copy link
Collaborator

(BRANCH): mercedes/list-view/16 merged into bmw/28

(DESCRIPTION): Create a popup slideout List view similar to the Log In popup. In this box, any found listings will appear and can be sorted by any property in ascending or descending order. They will be shown in minimized form with thumbnail images, and can be expanded for more information/detailed description by clicking on them. The sidebar should still be available for filtering.

Include the popups for markers into this because they will use the same code as the list view.

(COMPLETION REQUIREMENTS):Complete display of listings and expanding for detailed view.
#24 #26 #27

1. Address shows both address 1 and address 2 (if available).
2. #listings div is completely opaque
3. On window resize, the listing-view follows
4. #47 I want to do it here since it relates to how I build the list-view.
5. Users can only touch their own listings and account. No hacks!

To create the popups for the multi-listings. I am going to create a hash object that consists of the address as the key, and an array of strings where the strings are html sections that I simply insert into the modal template by iterating over the array. The hash objects are created on page load.

(PARENT TICKET): #5

(DEPENDENT TICKETS):#24 #26 #27 #55

@ghost ghost added this to the Phase [1] - Front Page milestone Jun 17, 2015
@Harmonickey Harmonickey self-assigned this Jun 17, 2015
@Harmonickey
Copy link
Owner

@Saurutobi What may be good to do here is
Inside of the popup modal...

  1. Display a horizontal bar of items that are used for filtering (basically making the sidebar filter functions that are vertically placed to be horizontally placed here).
  2. Update the horizontal filters to match the current vertical filters (which would be on the sidebar).
  3. Display would be underneath the horizontal bar and is a simple list. In each item there is a picture, price, and all other information about the listing (ideally in an organized rectangle area). There should be a margin of about 15 pixels or so between each listing.
  4. If you click somewhere on the listing, then there should be some functionality to contact the landlord in some fashion. Perhaps an easy form and Email button like how Zillow does it.

This same listing style (minus the filters) can be used for listing all of the user's apartment listings.

What do you think?

@Saurutobi
Copy link
Collaborator

I updated the description for this ticket a little. I think having 2 sets of filters would be confusing UI, so the sidebar should stay. Contacting and such should be added on further functionality in a future ticket.

@Harmonickey
Copy link
Owner

But when the modal pops up, the sidebar goes away and you'd have to switch back and forth to filter. If we just have the filter in the modal too, for this feature, then the user doesn't have to keep opening and closing the modal.

@Saurutobi
Copy link
Collaborator

Oh, I thought we were planning on keeping the sidebar there for doing this part.

@Harmonickey
Copy link
Owner

it's tough to get that to work because it's inherently not how the modals work, but it is possible.

I think we need more discussion on the matter to see what justin and will want given the two possibilities.

@Saurutobi
Copy link
Collaborator

ok, let's discuss this when #5 is done and it's time to work on this.

This was referenced Jun 23, 2015
@Harmonickey Harmonickey self-assigned this Jul 4, 2015
@Saurutobi Saurutobi modified the milestones: Phase [1] - Front Page, Phase [2] - Map and Filtering Jul 7, 2015
@Harmonickey
Copy link
Owner

In addition to this, I am going to include the popup dialogs for each marker. They are simply the list view but individualized, and they will be using the same individual high detail popup anyway.

@Harmonickey
Copy link
Owner

A lot of this is already created, but I'm going to fine tune the UI and how it looks. This ticket is all UI work, no backend.

@Harmonickey
Copy link
Owner

I think the listings should only show Address # and Address Street Name. I don't think city,state,country is necessary. It is necessary for the backend to pinpoint with latitude and longitude with google's api. Along with that, we need an "Address continued" section so that the apartment can be specified. It would be only used to concat with the address on the UI.

@Saurutobi
Copy link
Collaborator

yea, That's one of the notes from the meeting monday that Justin is writing
into a ticket. totally agree

On Fri, Jul 24, 2015 at 6:40 PM, Alex Ayerdi notifications@github.com
wrote:

I think the listings should only show Address # and Address Street Name. I
don't think city,state,country is necessary. It is necessary for the
backend to pinpoint with latitude and longitude with google's api. Along
with that, we need an "Address continued" section so that the apartment can
be specified. It would be only used to concat with the address on the UI.


Reply to this email directly or view it on GitHub
#16 (comment).

@Harmonickey
Copy link
Owner

That's right... I used the scroll bar for the lbkstudios home site, but never really put it to use in the end since I didn't want the mid-parts to scroll. I am using the slim-scroll library. It looks pretty good now!

@Harmonickey
Copy link
Owner

all the functionality is there, just needs better styleup, code review it anyway

@Saurutobi
Copy link
Collaborator

Details popup doesn't work

@Harmonickey
Copy link
Owner

This will be brought into the home page design ticket #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants