Logging in/out still needs some text fixes

[Saurutobi]

(BRANCH): mercedes/accounts/32

(DESCRIPTION):When creating a new account it says "Account Update Success" after putting in your bits. We should know whether it's an update or a create and display the proper information. Also, When Logging Out it just kinda does it, we should be showing a confirmation message. Also, Deleting an Account also a confirmation. Lastly: the delete account button should be in the update account thing. We don't wanna make deleting easy. It should be not easy.

The footer needs to be fixed too, it is not spanning the sidebar. The logo should be padded less too so that the sidebar filters can more easily be put in without being squished.

(COMPLETION REQUIREMENTS):
1. Creating Account, fix popup
2. Updated Popups and logout notification.
3. Delete button moved (update-modal)
4. Footer span 100% of sidebar
5. Logo padded less in sidebar so there is more space below.

(PARENT TICKET):none

(DEPENDENT TICKETS):none

[Harmonickey]

This is agreeable.
On Jul 3, 2015 3:43 PM, "Marcel Englmaier" notifications@github.com wrote:

(BRANCH):(branch name here)

(DESCRIPTION):When creating a new account it says "Account Update Success"
after putting in your bits. We should know whether it's an update or a
create and display the proper information. Also, When Logging Out it just
kinda does it, we should be showing a confirmation message.

(COMPLETION REQUIREMENTS):Updated Popups and logout notification

(PARENT TICKET):none

(DEPENDENT TICKETS):none

—
Reply to this email directly or view it on GitHub
#32.

[Harmonickey]

I am still unable to reproduce the first error.

[Saurutobi]

that's because you have an existing acocunt
wipe out the accounts collection and try again.

[Saurutobi]

also that branch name is shit. this clearly falls under Mercedes. it should be mercedes/accounts/32

[Harmonickey]

No, I created a whole new account, it still doesn't do it. Also, it's not clear where this branch falls under, since logging in needs to work for all the sections of the website.

[Harmonickey]

why not Leaser or Renter? Since logging in needs to work for them to even be functional.

[Harmonickey]

was not able to reproduce error. I removed the accounts and then added them back individually through UI, and then updated their information individually through UI, still nothing bad. Pushing this ticket through.

[Saurutobi]

I'm sending it back to you. I can't even create an account in Dev.

[Harmonickey]

okay, now the functionality works. Thanks for testing in Firefox.

[Saurutobi]

Also found another bug: Log in-> fb button->delete account->log in->fb button
The update account thing is now at the bottom of the screen.

[Saurutobi]

or the login thing. They're not at the top anymore

[Harmonickey]

dude, what the heck are you talking about. I cannot reproduce anything you're doing.

[Saurutobi]

[Saurutobi]

This is also Firefox.

[Harmonickey]

what is wrong?

[Saurutobi]

The login panel is not near the top, it looks like it comes up from the bottom.

[Harmonickey]

oh, it's just in the wrong position... hmm

[Harmonickey]

skipping code review, merging to dev for QA again

[Saurutobi]

branch nuked