Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect OS identification #60

Closed
RElesgoe opened this issue Jul 14, 2014 · 4 comments
Closed

Incorrect OS identification #60

RElesgoe opened this issue Jul 14, 2014 · 4 comments
Labels
Milestone

Comments

@RElesgoe
Copy link
Member

PvPGN thinks all of the Windows OSs are Windows XP

@HarpyWar HarpyWar added bug and removed bug labels Jul 16, 2014
HarpyWar added a commit that referenced this issue Jul 16, 2014
@HarpyWar HarpyWar added the bug label Jul 16, 2014
@HarpyWar
Copy link
Member

@RElesgoe
Copy link
Member Author

Have you tested this commit with Windows 8.1 yet? The statement on Microsoft's website suggest using the new Version Helper functions instead of GetVersion and GetVersionEx: http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972(v=vs.85).aspx

@HarpyWar
Copy link
Member

Yes, on Windows "8.1" it determines as "8" now.

@RElesgoe
Copy link
Member Author

We should add code to check for versions higher than 8.1 in case future servers are on older versions of this PvPGN. If another Windows is released, the current code will assume 8.1.

IsWindowsVersionOrGreater(6, 4, 0)
Should then go to the default case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants