Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website for this project #763

Closed
wants to merge 209 commits into from
Closed

Website for this project #763

wants to merge 209 commits into from

Conversation

avinal
Copy link
Contributor

@avinal avinal commented Feb 13, 2021

Description

  • All the readme markdown files has been changed to restructuredtext to better suit with sphinx and will also prove more powerful syntax for the repository itself
  • Page publishing action has been added
  • Markdown files have been removed
  • Scripts file has not been touched
  • Check it out badge added to each readme

Check current deployment at https://avinal.space/Rotten-Scripts/

Fixes #656
See Discussions at #755

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@avinal
Copy link
Contributor Author

avinal commented Feb 13, 2021

Hello @HarshCasper, I know this is a very large change to merge, so we may have a review period of 2-3 weeks, and I am happy to resolve any conflicts, (may need permission to the repo).

@avinal avinal changed the title Website rst Website for this project Feb 13, 2021
@HarshCasper
Copy link
Owner

Hello @HarshCasper, I know this is a very large change to merge, so we may have a review period of 2-3 weeks, and I am happy to resolve any conflicts, (may need permission to the repo).

Sure. Can you please drop me a mail here and I will share the due permissions sure after. It will take at least a week for review and we can hopefully deploy it this week.

@HarshCasper
Copy link
Owner

Hello @HarshCasper, I know this is a very large change to merge, so we may have a review period of 2-3 weeks, and I am happy to resolve any conflicts, (may need permission to the repo).

Sure. Can you please drop me a mail here and I will share the due permissions sure after. It will take at least a week for review and we can hopefully deploy it this week.

Tagging @vybhav72954 and @seema1711 who might be able to help us with the review.

@avinal
Copy link
Contributor Author

avinal commented Feb 14, 2021

Hello @HarshCasper, I know this is a very large change to merge, so we may have a review period of 2-3 weeks, and I am happy to resolve any conflicts, (may need permission to the repo).

Sure. Can you please drop me a mail here and I will share the due permissions sure after. It will take at least a week for review and we can hopefully deploy it this week.

Tagging @vybhav72954 and @seema1711 who might be able to help us with the review.

Feel free to ask doubts about restructuredtext and sphinx syntax, Its mostly similar to markdown, should be easier to catch up for you guys. Again in any case I am just a ping away.

@vybhav72954
Copy link
Collaborator

@avinal @HarshCasper @seema1711 Let's do this 🤩

@HarshCasper
Copy link
Owner

@vybhav72954 and @avinal : I will share the collaborator access to both of you for the repository. Since I have both of your Mail IDs, I can setup some day to have a short call ( ~15 mins) so that we can start reviewing it up.

@avinal
Copy link
Contributor Author

avinal commented Feb 14, 2021

Yeah sure, we can have a meet. 🤩

@avinal
Copy link
Contributor Author

avinal commented Apr 27, 2021

The pull request was not reviewed in 3 months. It is stale and unusable now. Closing it for good.👎🏼

@avinal avinal closed this Apr 27, 2021
@vybhav72954
Copy link
Collaborator

The pull request was not reviewed in 3 months. It is stale and unusable now. Closing it for good.👎🏼

Hey Avinal, thank you so much for your time. During GSSoC, because of an upsurge in participants, we were not able to look into it. The website project is still in the back of our mind, possibly after GSSoC we can start everything together once again.

@HarshCasper
Copy link
Owner

The pull request was not reviewed in 3 months. It is stale and unusable now. Closing it for good.👎🏼

Hello @avinal

We are sorry for this experience and truly believe that you worked quite hard on it. We have kick-started the development of a new website and we would use your pull request as a base to start the work from. Thanks for all your contributions and appreciate your work over the same. We have been at fault of not being able to merge it earlier due to GSSoC and other personal commitments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants