Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best practices for links. #23

Closed
2 tasks
HarshKapadia2 opened this issue Jun 21, 2020 · 8 comments
Closed
2 tasks

Best practices for links. #23

HarshKapadia2 opened this issue Jun 21, 2020 · 8 comments
Assignees
@Rodrigue819
Labels
enhancement New feature or request good-first-issue Good for newcomers hacktoberfest Issue for Hacktoberfest participants

Comments

@HarshKapadia2
Copy link
Owner

HarshKapadia2 commented Jun 21, 2020 •
edited

  • Correct hyperlinks with text as 'here' or 'this' with meaningful text. (Might have to change the structure of sentence, obviously keeping the meaning and tense the same.)
    Eg:

  • Remove hyperlinks on pictures.
@HarshKapadia2 HarshKapadia2 added enhancement New feature or request good-first-issue Good for newcomers labels Jun 21, 2020
@HarshKapadia2 HarshKapadia2 mentioned this issue Aug 4, 2020
Closed
@HarshKapadia2 HarshKapadia2 added the hacktoberfest Issue for Hacktoberfest participants label Sep 25, 2020
@Riya-code
Copy link

I would like to take it

@HarshKapadia2
Copy link
Owner Author

Go ahead @Riya-code. Please remember to follow the instructions in the CONTRIBUTING.md file.

@Riya-code
Copy link

I think I might take a longer time. You can assign it to someone else :)

@HarshKapadia2
Copy link
Owner Author

Okay. Let me know if you want to do it and I'll re-assign you if someone else hasn't already taken it.

@Riya-code
Copy link

Riya-code commented Oct 2, 2020 •
edited

Ok. Thanks.

@HirushaR
Copy link

HirushaR commented Oct 5, 2020

I would like to take it

Rodrigue819 pushed a commit to Rodrigue819/git_basics that referenced this issue Oct 9, 2020
🐛 fix: Fix link description (HarshKapadia2#23)
247a498
@Rodrigue819
Copy link

I tought I was going in to give a hand, but I think I did all of them. PR is open!

Rodrigue819 pushed a commit to Rodrigue819/git_basics that referenced this issue Oct 9, 2020
🐛 fix: Fix link description (HarshKapadia2#23)
78a18cc
Rodrigue819 pushed a commit to Rodrigue819/git_basics that referenced this issue Oct 9, 2020
🐛 fix: Fix type and generate index file. (HarshKapadia2#23)
cdc6ab1
Rodrigue819 pushed a commit to Rodrigue819/git_basics that referenced this issue Oct 9, 2020
🐛 fix: Remove link from images (HarshKapadia2#23)
90d3eda
@Rodrigue819 Rodrigue819 mentioned this issue Oct 9, 2020
Merged
This was referenced Oct 9, 2020
Merged
Merged
@HarshKapadia2
Copy link
Owner Author

The PRs for this issue are #46 and #49.

Rodrigue819 pushed a commit to Rodrigue819/git_basics that referenced this issue Oct 10, 2020
Fixing the link (HarshKapadia2#23)
84f3022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rodrigue819 Rodrigue819

Labels
enhancement New feature or request good-first-issue Good for newcomers hacktoberfest Issue for Hacktoberfest participants
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Rodrigue819 @HirushaR @HarshKapadia2 @Riya-code