New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My branch #83
My branch #83
Conversation
@KartikSoneji and @HarshKapadia2 please have a look . |
This is a proper draft pull request, good job!
|
okay @KartikSoneji where to see these errors. i am geeting mail regarding github page workflow failed. |
@KartikSoneji is build setup error has been resolved ?? also is this much content is ok? some of the things I have written by my own so please check. also one ques as this repo is part of Hacktoberfest can this issue get a label of hacktoberfest? |
The workflow has been updated to handle PRs. Please update your branch with the latest commits. Also, you have used syntax arbitrarily. For bullet points, please use Once the PR has been merged, the |
okay, sure I will do it. |
@HarshKapadia2 I have made some commits, changed the syntax. Please check is it working or not. |
okay sure, will add these changes also. |
@KartikSoneji @HarshKapadia2 |
@KartikSoneji @HarshKapadia2 Please Review it. |
Hey @shefali12-ab I would recommend that you try to build the web site. You have not linked the files properly, so it is not appearing in the final build. Please read the 'Parsing' section in the Please test the final site before pushing. You have a typo in the file name as well. So please go through the |
Also, the CI/CD workflow has been modified again, so I would recommend updating your branch with the latest commits. |
There are a LOT of spelling errors as well. Please use a spell checker plugin. (For VS Code) |
@HarshKapadia2 I have made the required, i need help please tell me how to perform testing of website. as I have read contributing.md and there it was written to generate website in build directory and run sh build.sh command . i didn't understand like where to run these commands( i am doing it like opening new terminal in open_source_programs file and typed sh build.sh command )but it didn't worked .please guide me. |
@HarshKapadia2 Please review it . |
As mentioned in the |
Please remove all the logos as well. They are not required. |
I think the logos will help differentiate between programs at a glance. |
It seems that the Table of Contents (ToC) is missing in your output. Weird. In the image below, please note how all programs are appearing in the ToC rather than just the heading 'Open Source Programs'. Please look into your heading levels (no. of Please change the title of the 'Official Website' table column to 'Links'. Some of the empty table cells have a single dash while other have three hyphens. Please make them all long dashes. The middle column line of the table is thicker than the rest. Why is that? Please make it similar to the others. The main branch has been updated with some code, so please update your branch. |
Any updates, @shefali12-ab? |
@HarshKapadia2 Need to fix the table column. will update you by tomorrow. |
@HarshKapadia2 I am not able to figure out why the middle column of the table is thicker. the syntax is same as of other columns. |
Okay, no issues. Have you made all the other changes and checked the built version thoroughly for all the suggested changes? |
The aspect ratio of the GSoC and GSoD images is improper. Please correct that and push a commit to this PR. |
I have made changes and pushed it. |
@KartikSoneji please check and suggest changes. I have made all the changes as per my liking. Also, should some of the commits in between be squashed before merging? |
@shefali12-ab please check the changes in my commits. I corrected a LOT of grammar and formatting errors. Please take care while contributing to documentation projects in the future. |
Yeah, sure I will check them again. This was my first open-source contribution in documentation, which I will take care of in the future, further thank you for your guidance as I have learned to use assciidoctor and Github :)) by contributing to this repo. |
Great! Thank you for contributing and unless @KartikSoneji suggests any changes, this PR looks good to be merged! |
Added content of opensource programs added content in my_branch Modified the content Added the required Changes made changes as required made changes as required
Increase version in service worker and change order in `refs/misc.adoc`
0e0ce14
to
ea8d95a
Compare
Hey @shefali12-ab I rebased the commits to maintain a clean history and force pushed to your branch. I will be merging the PR now. 🎉 Thank you SO much for your contribution! I am impressed by the way you did not give up despite there being a lot changes. This PR has gone on for almost a month now and you kept improving upon your work. That's awesome! I did help you out a little in the end, but I'm sure you'll get better with more PRs. Do work on your language skills and please read the All the best! Feel free to reach out for any help. |
@HarshKapadia2 Thank you so much for merging PR, this appreciation means a lot to me, I will surely improve my skills. |
Added the required content in page opensource_programs.adoc
I have added these changes in new branch named my_branch. this much content i will change font style and format text afterwards.
please review it .
closes #83