Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

Form validation #28

Closed
HarshdipD opened this issue Oct 21, 2020 · 1 comment · Fixed by #29
Closed

Form validation #28

HarshdipD opened this issue Oct 21, 2020 · 1 comment · Fixed by #29
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@HarshdipD
Copy link
Owner

This is a good first issue to validate the input form before sending an API call.

To Reproduce
Steps to reproduce the behavior:

  1. Click the extension
  2. Enter fields but don't choose any list
  3. Click 'Add to Trello' button
  4. Error is shown and refreshing it means all info is gone

Expected behavior
The screen should tell users to choose a list before sending the POST request, preserving the data.

Further enhancement
The error div should have a link to hide the error div and display the original div again, in case the error is not related to form invalidation.
@HarshdipD HarshdipD added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Oct 21, 2020
@slaterslater
Copy link
Contributor

Can I be assigned to this? I'd like to give it a try

slaterslater added a commit to slaterslater/job-tracker that referenced this issue Oct 21, 2020
@slaterslater
Fixes HarshdipD#28: Form validation
2d1f91b
@HarshdipD HarshdipD linked a pull request Oct 21, 2020 that will close this issue
Fixes #28: Form validation #29
Merged
HarshdipD added a commit that referenced this issue Oct 21, 2020
@HarshdipD
Merge pull request #29 from slaterslater/issue-28
2ad389c 
Fixes #28: Form validation
HarshdipD added a commit that referenced this issue Oct 21, 2020
@HarshdipD
Revert "Fixes #28: Form validation"
6da5d90
HarshdipD added a commit that referenced this issue Oct 21, 2020
@HarshdipD
Merge pull request #32 from HarshdipD/revert-29-issue-28
77589ea 
Revert "Fixes #28: Form validation"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #28: Form validation slaterslater/job-tracker
2 participants
@slaterslater @HarshdipD