Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds safe names, tests, and more flexible table values #3

Merged
merged 2 commits into from Mar 2, 2018
Merged

Adds safe names, tests, and more flexible table values #3

merged 2 commits into from Mar 2, 2018

Conversation

humphreyja
Copy link
Member

@humphreyja humphreyja commented Mar 2, 2018 •
edited

closes #2
closes #1

@coveralls
Copy link

coveralls commented Mar 2, 2018 •
edited

Pull Request Test Coverage Report for Build 4

  • 5 of 5 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 77.647%
Totals Coverage Status
Change from base Build 2: 0.5%
Covered Lines: 53
Relevant Lines: 63
💛 - Coveralls

@humphreyja humphreyja merged commit 30c8c9b into master Mar 2, 2018
@humphreyja humphreyja deleted the 2-safe-names-and-better-testing branch March 2, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarydkrish jarydkrish jarydkrish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special characters in name Add tests
3 participants
@humphreyja @coveralls @jarydkrish