Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass props to transform #3

Merged
merged 3 commits into from Jan 4, 2019
Merged

Pass props to transform #3

merged 3 commits into from Jan 4, 2019

Conversation

humphreyja
Copy link
Member

Allows for passing props to the transform function. NOTE: this is a breaking change. It changes the first argument of the transform function to the actual DOM instance allowing access of value, ref, props, and elementName. This can be added to later which is why it is a required change.

@humphreyja
Copy link
Member Author

Also, this adds mount as an alias to render for testing.

closes #2

@coveralls
Copy link

coveralls commented Jan 3, 2019

Pull Request Test Coverage Report for Build 11

  • 18 of 21 (85.71%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.5%) to 82.39%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DocFluxTest.js 5 6 83.33%
src/DocFlux.js 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
src/DocFlux.js 1 81.08%
Totals Coverage Status
Change from base Build 9: -3.5%
Covered Lines: 78
Relevant Lines: 94

💛 - Coveralls

@humphreyja humphreyja merged commit 04498fe into master Jan 4, 2019
@humphreyja humphreyja deleted the pass-props-to-transform branch January 4, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants