Itemlog #1
Merged
Itemlog #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leStatus.cpp and can make build success
…erializeAcquireNewBlock method can build and run successful
…to shared memory, and add unit test for sharedMemoryManager
Eric5553
reviewed
Dec 18, 2017
| int32_t SIZE_OF_FILE = 20 * 1024 * 1024 * 1024;//the size of the SSD file, default is 20GB | ||
| int32_t SIZE_OF_BLOCK = 64 * 1024 * 1024; //the size of the bucket size | ||
| int64_t SHM_SIZE = 4096;//the size of shared memory | ||
| int64_t SIZE_OF_FILE = 20 << 30;//the size of the SSD file, default is 20GB |
There was a problem hiding this comment.
you should still use 20 * 1024 * 1024 * 1024, that's more readable
Eric5553
reviewed
Dec 18, 2017
| // | ||
| // int pid = DecodeFixed32(res + offset); | ||
| // LOG(INFO, "FileSystemImpl::readFileStatusFromLog pid = %d", pid); | ||
| // close(logFd); |
There was a problem hiding this comment.
Are the comments still valuable? Remove junk codes, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the shared memory status have been write to log file, and test success.