-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to scope text searches to a class or id. #41
Conversation
@@ -1,6 +1,8 @@ | |||
defmodule Hound.RequestUtils do | |||
@moduledoc false | |||
|
|||
@retry_time Application.get_env(:hound, :retry_time, 250) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@jontonsoup Nice stuff. Just skimmed through it. I hope it's ok if I can try/run this and merge this tomorrow. |
No rush! I'd rather a thorough second set of eyes. I could see the two public functions getting abstracted further-- they aren't as DRY as I'd like, but my elixir isn't as good as I'd like to figure it out. On Fri, Jul 3, 2015 at 11:06 AM, Akash Manohar notifications@github.com
|
@HashNuke hows it look? |
@jontonsoup Sorry. Will look at it soon. Came to Malaysia on an impulse trip. Just found good internet in a new apartment. |
Just making sure you didn't forget. :) On Wed, Jul 8, 2015 at 10:36 AM, Akash Manohar notifications@github.com
|
@jontonsoup I'm back home from the trip and just started working. Will try this out tomorrow. Thank you for your patience :) |
Add the ability to scope text searches to a class or id.
@jontonsoup Sorry about the delay. I just merged this in. Thank you very much ~! |
Awesome! On Sun, Jul 19, 2015 at 1:44 PM, Akash Manohar notifications@github.com
|
@HashNuke Add the ability to scope text searches for a class or id.
Also added in a second commit the ability for the user to config the retry wait time.
Solves this: #38