Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to scope text searches to a class or id. #41

Merged
merged 2 commits into from
Jul 19, 2015

Conversation

jontonsoup
Copy link
Contributor

@HashNuke Add the ability to scope text searches for a class or id.
Also added in a second commit the ability for the user to config the retry wait time.

Solves this: #38

@jontonsoup jontonsoup mentioned this pull request Jul 2, 2015
@jontonsoup jontonsoup changed the title Add the ability to scope text searches for a class or id. Add the ability to scope text searches to a class or id. Jul 2, 2015
@@ -1,6 +1,8 @@
defmodule Hound.RequestUtils do
@moduledoc false

@retry_time Application.get_env(:hound, :retry_time, 250)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HashNuke
Copy link
Owner

HashNuke commented Jul 3, 2015

@jontonsoup Nice stuff. Just skimmed through it. I hope it's ok if I can try/run this and merge this tomorrow.

@jontonsoup
Copy link
Contributor Author

No rush! I'd rather a thorough second set of eyes.

I could see the two public functions getting abstracted further-- they aren't as DRY as I'd like, but my elixir isn't as good as I'd like to figure it out.

On Fri, Jul 3, 2015 at 11:06 AM, Akash Manohar notifications@github.com
wrote:

@jontonsoup Nice stuff. Just skimmed through it. I hope it's ok if I can try/run this and merge this tomorrow.

Reply to this email directly or view it on GitHub:
#41 (comment)

@jontonsoup
Copy link
Contributor Author

@HashNuke hows it look?

@HashNuke
Copy link
Owner

HashNuke commented Jul 8, 2015

@jontonsoup Sorry. Will look at it soon. Came to Malaysia on an impulse trip. Just found good internet in a new apartment.

@jontonsoup
Copy link
Contributor Author

Just making sure you didn't forget. :)

On Wed, Jul 8, 2015 at 10:36 AM, Akash Manohar notifications@github.com
wrote:

@jontonsoup Sorry. Will look at it soon. Came to Malaysia on an impulse trip. Just found good internet in a new apartment.

Reply to this email directly or view it on GitHub:
#41 (comment)

@HashNuke
Copy link
Owner

@jontonsoup I'm back home from the trip and just started working. Will try this out tomorrow. Thank you for your patience :)

HashNuke added a commit that referenced this pull request Jul 19, 2015
Add the ability to scope text searches to a class or id.
@HashNuke HashNuke merged commit 41db011 into HashNuke:master Jul 19, 2015
@HashNuke
Copy link
Owner

@jontonsoup Sorry about the delay. I just merged this in. Thank you very much ~!
I switched the arg order for the matcher for uniformity sake (moved selector to first arg).

@jontonsoup
Copy link
Contributor Author

Awesome!

On Sun, Jul 19, 2015 at 1:44 PM, Akash Manohar notifications@github.com
wrote:

@jontonsoup Sorry about the delay. I just merged this in. Thank you very much ~!

I switched the arg order for the matcher for uniformity sake (moved selector to first arg).

Reply to this email directly or view it on GitHub:
#41 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants