-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata functionality. #98
Conversation
7465ff4
to
08ae32e
Compare
@tuvistavie Looks good. Would be nice to have a wrapper around it though (and call it as support for ecto-sandboxed tests). Users/devs don't need to know that we are using user-agent string to make it work. |
@HashNuke Thanks for the feedback! What do you think? |
@tuvistavie ah right. My bad. Just noticed the P.S: Feel free to make releases whenever you think it is appropriate. Hence the hex access :) |
on_exit fn-> Hound.end_session end | ||
pid = Hound.start_session(unquote(opts)) | ||
on_exit fn -> | ||
Hound.end_session(pid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This callback should not be required as start_session should monitor the caller and shut it down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to check this, thank you.
It looks great, I have added some comments. :) |
08ae32e
to
0e91ced
Compare
@HashNuke Thank you! I will make a new release once we conclude the discussion in phoenixframework/phoenix_ecto#41 and I merge this PR 😃 @josevalim Thank you very much for the feedback. I just updated the PR, integrating the format you suggested. |
|
This PR will allow us to pass custom metadata to the webdriver, through the user agent string,
which should be enough to handle the use case described in #71.
For example
To make this possible, additional capabilities are now passed through the
:driver
keys, which is a breaking change.What do you think?
/cc @HashNuke @josevalim