Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test for each hashcat mode, updated the database #113

Merged
merged 2 commits into from
Jun 13, 2021
Merged

Conversation

amadejpapez
Copy link
Member

@amadejpapez amadejpapez commented Jun 13, 2021

With this PR we are testing every single hashcat mode we have! (#62) There is also a test testing if all tests exist. If one hash type with hashcat mode is added and there is no test, it will fail. So we will always be testing every single one! :D

Results of testing:

  • some hashes were not correctly detected, so regex was updated
  • there were 2 wrong hashcat modes specified
  • 6 hashes were missing hashcat modes
  • We were showing some hashcat modes that are no longer supported in the latest version of hashcat. I left them in place but added a description, telling users that it is no longer supported or that it is only supported in the legacy hashcat version.

Where we used links in description, I have moved text out of the link and now the link is under See more. The problem was that if a terminal did not support links, there would be nothing in the description, now only See more will be missing.

@bee-san bee-san merged commit daf871a into main Jun 13, 2021
@bee-san bee-san deleted the hashcat-test branch June 13, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants