-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scss support and make nodemon development server #50
Conversation
I feel stripping out support for vanilla css, and only supporting one CSS preprocessor is a step in the wrong direction. Could you alter this PR to add Sass support rather than a full swap out? |
Agree with @beaucharman ! |
makes sense, I'll modify |
@evansendra @beaucharman @mayankchd Why use SCSS if exists PostCSS and SCSS parser for PostCSS? |
Thanks @evansendra. Looks good! |
@beaucharman @mayankchd this should be modified appropriately now. Let me know if you see anything else that needs fixing before a potential merge! |
@carloscuatin can we create a seperate PR for nodemon? so we can get this merged ASAP @beaucharman I agree, what if we want to do inline styling like radium? I think adding scss support should be applied to the scaffolding aspect so you can choose at start of the project @prank7 @mayankchd @carloscuatin thoughts? |
Yeah if we want to add this to the scaffolding part I think that could be a separate PR in mern-cli and then I could remove the style folder with the SCSS and just leave the rules in the webpack config files |
What's the status on this? Would be great to have SCSS support in master. The scaffolding could maybe be added later right? |
Hey @yn5 I'll take a look at this later this weekend! |
Hey @evansendra wanted to let you know that I tested this code and it worked perfectly for me. Also, I think that you missed an opportunity to name the script sassinate. ^___^ |
Hi there, also wanted to comment and say thanks for this @evansendra. Manually added this code to my project and SCSS is working well and the "watch-sass" is a great addition. Cheers! |
PostCSS with css-modules is implemented on v2 branch(510101f). Closing this in favour of that. Thank you very much for your effort, @evansendra. |
SCSS support in development and production.
In dev, works by bundling with the javascript so that it works with the HMR. In production, works by generating app.css using
sass
command then minifying to app.min.css and inserting intoclient/index.js
.To test:
npm start
works as intendednpm run-script start:prod
works as intended