Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scss support and make nodemon development server #50

Closed
wants to merge 9 commits into from
Closed

add scss support and make nodemon development server #50

wants to merge 9 commits into from

Conversation

evansendra
Copy link

SCSS support in development and production.

In dev, works by bundling with the javascript so that it works with the HMR. In production, works by generating app.css using sass command then minifying to app.min.css and inserting into client/index.js.

To test:

  • confirm npm start works as intended
  • confirm npm run-script start:prod works as intended

@beaucharman
Copy link
Contributor

I feel stripping out support for vanilla css, and only supporting one CSS preprocessor is a step in the wrong direction. Could you alter this PR to add Sass support rather than a full swap out?

@mayankchd
Copy link
Contributor

Agree with @beaucharman !

@evansendra
Copy link
Author

makes sense, I'll modify

@carloscuatin carloscuatin mentioned this pull request Feb 29, 2016
@evansendra evansendra mentioned this pull request Feb 29, 2016
@pomeo
Copy link
Contributor

pomeo commented Feb 29, 2016

@evansendra @beaucharman @mayankchd Why use SCSS if exists PostCSS and SCSS parser for PostCSS?
PostCSS at the moment already have among modules mern-starter.

@raksonibs
Copy link
Contributor

Thanks @evansendra. Looks good!

@evansendra
Copy link
Author

@beaucharman @mayankchd this should be modified appropriately now. Let me know if you see anything else that needs fixing before a potential merge!

@carloscuatin
Copy link
Contributor

I think the style file must be imported on the client and define it in a variable in webpack with this make the user choose the value of that variable

sass

@SOSANA
Copy link
Contributor

SOSANA commented Mar 2, 2016

@carloscuatin can we create a seperate PR for nodemon? so we can get this merged ASAP

@beaucharman I agree, what if we want to do inline styling like radium? I think adding scss support should be applied to the scaffolding aspect so you can choose at start of the project

@prank7 @mayankchd @carloscuatin thoughts?

@evansendra
Copy link
Author

Yeah if we want to add this to the scaffolding part I think that could be a separate PR in mern-cli and then I could remove the style folder with the SCSS and just leave the rules in the webpack config files

@yn5
Copy link
Contributor

yn5 commented Apr 20, 2016

What's the status on this? Would be great to have SCSS support in master. The scaffolding could maybe be added later right?

@raksonibs
Copy link
Contributor

Hey @yn5 I'll take a look at this later this weekend!

@Bonitis
Copy link

Bonitis commented Apr 27, 2016

Hey @evansendra wanted to let you know that I tested this code and it worked perfectly for me. Also, I think that you missed an opportunity to name the script sassinate. ^___^

@stephenrichter
Copy link

Hi there, also wanted to comment and say thanks for this @evansendra. Manually added this code to my project and SCSS is working well and the "watch-sass" is a great addition. Cheers!

@somus somus mentioned this pull request May 26, 2016
12 tasks
@somus
Copy link
Contributor

somus commented May 31, 2016

PostCSS with css-modules is implemented on v2 branch(510101f). Closing this in favour of that. Thank you very much for your effort, @evansendra.

@somus somus closed this May 31, 2016
@Bonitis Bonitis mentioned this pull request Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.