Promising API + Minimal House keeping #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply changing awfully looking callbacks to promises.
houssem-yahiaoui
force-pushed
the
master
branch
from
3dcf48c
to
9e5a258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR holds the following :
1 - Minimal house keeping.
A - Introducing the Config folder where all Express, Mongoose and future module will be configured into.
B - Cleaning the Server.js file under Server folder for SOC sakes.
2 - Since we're configuring mongoose with native promises, i've pushed the call to the max using, Then and Catch for responses and errors + changing the call over the remove with cuid to more native call using findOneAndRemove
Plus the code is well linted and all tests are being passed, i hope this PR will help.