Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update api structure #312

Closed
wants to merge 5 commits into from
Closed

update api structure #312

wants to merge 5 commits into from

Conversation

lwhiteley
Copy link

@lwhiteley lwhiteley commented Jun 5, 2017

Thanks for this great starter.

I added some changes that i think may be beneficial

Changes:

  • Update structure of the api to a folder per path, makes it easier to maintain related files, instead of searching multiple folders for related files
    • services, model, various tests, conteollers and route can all live in one area
  • iterate over routes to append to express (reduces changes to server.js for additional routes)
  • only add dummydata in development (This was failing the tests by adding two extra posts when the tests started)
  • Another thing failing the tests was the beforeEach was not using async-await for the async functions, which gave variable results for the tests. Now its consistent!
  • Some of the other tests did not wait on the respective posts to be created either. so added await

Can discuss but i find this a little easier to manage

@mannyhenri mannyhenri self-requested a review June 1, 2018 21:37
@mannyhenri mannyhenri added the v3.0.0 CLI/devtools optimization/improvements label Jun 1, 2018
@mannyhenri mannyhenri added this to To do in MERN Roadmap via automation Jun 1, 2018
@mannyhenri mannyhenri added this to the 3.0.0 milestone Jun 1, 2018
@mannyhenri mannyhenri added V2.9.0 Express & server updates and removed v3.0.0 CLI/devtools optimization/improvements labels Jun 1, 2018
@mannyhenri mannyhenri modified the milestones: 3.0.0, 2.9.0 Jun 1, 2018
@lwhiteley lwhiteley closed this Aug 9, 2019
MERN Roadmap automation moved this from To do to Done Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2.9.0 Express & server updates
Projects
MERN Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants