Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check missing translations #366

Closed
wants to merge 2 commits into from

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Oct 27, 2023

Acceptance Criteria

  • We should include a new script that checks for missing translations in the locale/texts.pot

Sample output:

Missing translation for msgid "General Settings" (src/screens/Settings.js:102)
Missing translation for msgid "Developer Settings" (src/screens/Settings.js:174)
Missing translation for msgid "Network Settings" (src/screens/Settings.js:176)
Missing translation for msgid "There was an error connecting. Please try again later." (src/screens/WalletConnect/WalletConnectList.js:33)
Missing translation for msgid "Add" (src/screens/WalletConnect/WalletConnectList.js:111)
Missing translation for msgid "End session" (src/screens/WalletConnect/WalletConnectList.js:117)
Missing translation for msgid "This will disconnect the session." (src/screens/WalletConnect/WalletConnectList.js:117)
Missing translation for msgid "End" (src/screens/WalletConnect/WalletConnectList.js:119)
Missing translation for msgid "Wallet Connect Sessions" (src/screens/WalletConnect/WalletConnectList.js:137)
Missing translation for msgid "Manual Connection" (src/screens/WalletConnect/WalletConnectManual.js:39)
Missing translation for msgid "Wallet Connect URI" (src/screens/WalletConnect/WalletConnectManual.js:45)
Missing translation for msgid "Connect" (src/screens/WalletConnect/WalletConnectScan.js:34)
Missing translation for msgid "Manual" (src/screens/WalletConnect/WalletConnectScan.js:41)
Missing translation for msgid "Custom Network Settings" (src/screens/NetworkSettings/CustomNetworkSettingsScreen.js:15)
Missing translation for msgid "Updating custom network settings..." (src/screens/NetworkSettings/helper.js:4)
Missing translation for msgid "nodeUrl is required." (src/screens/NetworkSettings/CustomNetworkSettingsScreen.js:53)
Missing translation for msgid "explorerUrl is required." (src/screens/NetworkSettings/CustomNetworkSettingsScreen.js:57)
Missing translation for msgid "explorerServiceUrl is required." (src/screens/NetworkSettings/CustomNetworkSettingsScreen.js:61)
Missing translation for msgid "Node URL" (src/screens/NetworkSettings/CustomNetworkSettingsScreen.js:200)
Missing translation for msgid "Explorer URL" (src/screens/NetworkSettings/CustomNetworkSettingsScreen.js:209)
Missing translation for msgid "Explorer Service URL" (src/screens/NetworkSettings/CustomNetworkSettingsScreen.js:218)

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso force-pushed the chore/check-missing-translations branch from 60e215a to 90607cb Compare October 27, 2023 19:29
@andreabadesso andreabadesso self-assigned this Oct 27, 2023
@andreabadesso andreabadesso added the enhancement New feature or request label Oct 27, 2023
Comment on lines +40 to +41
- name: Check for missing translations
run: make check_missing_translations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding this to the current CI workflow, we trigger an error because of the current 33 missing translations.

We could either:

  • Add them within the scope of this PR or;
  • Leave the workflow unchanged and add the translations + workflow on another PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're going to be added after @alexruzenhack PR's are merged

@andreabadesso andreabadesso force-pushed the chore/check-missing-translations branch from 90607cb to b5e2fb5 Compare November 8, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants