Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(17) refactor: AlertUI color #371

Merged
merged 4 commits into from
Nov 1, 2023
Merged

(17) refactor: AlertUI color #371

merged 4 commits into from
Nov 1, 2023

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Oct 31, 2023 •
edited

Acceptance Criteria

  • Keep consistency with other components colors
  • Remove unused colors

Note

This PR complies with the designer decision. See the discussion.

Alert color on network status bar:

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack changed the title refactor: AlertUI color (17) refactor: AlertUI color Oct 31, 2023
@alexruzenhack alexruzenhack self-assigned this Oct 31, 2023
@alexruzenhack alexruzenhack mentioned this pull request Oct 31, 2023
Merged
1 task
pedroferreira1
pedroferreira1 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@pedroferreira1 pedroferreira1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the colors are the same, does it make sense to update the code for the warning boxes to use this same constant in the styles/themes.js file?

Base automatically changed from feat/ds-translation to dev November 1, 2023 16:02
@alexruzenhack alexruzenhack merged commit 74e4a8f into dev Nov 1, 2023
2 checks passed
@alexruzenhack alexruzenhack deleted the refactor/ds-alert-ui branch November 1, 2023 16:13
@GraoMelo GraoMelo mentioned this pull request Jan 1, 2024
Open
@GraoMelo GraoMelo mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
refactor
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexruzenhack @pedroferreira1 @andreabadesso