fix: component SendAddressInput #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
requested changes
Nov 3, 2023
| @@ -434,7 +435,7 @@ msgid "Try again" | |||
| msgstr "" | |||
|
|
|||
| #: src/screens/LoadWalletErrorScreen.js:21 | |||
| #: src/screens/PinScreen.js:265 | |||
| #: src/screens/PinScreen.js:268 | |||
There was a problem hiding this comment.
Why is this line being changed? You didn't change anything in PinScreen, am I missing something?
There was a problem hiding this comment.
Oh! I ran the translation script to get it updated.
There was a problem hiding this comment.
Ok, so dev was outdated, which is weird, can you please check by running the script on the unchanged dev branch?
There was a problem hiding this comment.
I will run, but it may have happened during the many rebases.
There was a problem hiding this comment.
I checked your script in the dev:
- extract the patch:
git format-patch -1 90607cb1f682eb4fe2d6ae8330cb7155e1254221- apply:
git apply 0001-refactor-check_pot-now-checks-for-missing-translatio.patch- run check:
make check_missing_translations- output:
✔ [ttag] translations extracted to /var/.../new.pot
check_pot: Checking missing translations on pot file...
|
This is actually a fix, not a refactor, right? |
- Change the component class to component function - Extend validateAddress utility function to receive the network as second argument - Get the network from redux state
alexruzenhack
changed the title
alexruzenhack
force-pushed
the
feat/ds-adjustments
branch
from
ddde4c3
to
30152fc
Compare
andreabadesso
approved these changes
Nov 8, 2023
pedroferreira1
approved these changes
Nov 8, 2023
Co-authored-by: Pedro Ferreira <pedro@hathor.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
second argument
ds-refactor-send-address-input-clip.mp4
Security Checklist