chore: version bump pr template #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
force-pushed
the
chore/version-bump-pr-template
branch
from
2ca7fb9
to
e15487e
Compare
andreabadesso
force-pushed
the
chore/version-bump-pr-template
branch
from
e15487e
to
e0a8fb5
Compare
luislhl
reviewed
Nov 6, 2023
| @@ -0,0 +1,13 @@ | |||
| ### Acceptance Criteria | |||
| - Include here all things that this PR should solve | |||
There was a problem hiding this comment.
question: Should we change this to something like: "Include links to all PRs that will be included in this version"?
There was a problem hiding this comment.
I think we should, done in 6c72884
luislhl
reviewed
Nov 6, 2023
| - [ ] Make sure you updated the `versionName` with the appropriate version, including the release candidate number in `android/app/build.gradle` | ||
|
|
||
| ### Security Checklist | ||
| - [ ] Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us. |
There was a problem hiding this comment.
thought: Maybe this is unnecessary in this template. What do you think?
There was a problem hiding this comment.
I agree, done in 259bf8a
pedroferreira1
approved these changes
Nov 7, 2023
pedroferreira1
approved these changes
Nov 8, 2023
luislhl
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist