Docs: QA steps to validate QR Code scanner #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
requested changes
Nov 14, 2023
QA.md
Outdated
Comment on lines
89
to
91
| 1. Take a screenshot of the QR Code and open that screenshot in another device | ||
| 1. Use the Mobile Wallet QR code scanner to read this screenshot | ||
| 1. Pay the Payment Request using the same wallet used to generate it |
There was a problem hiding this comment.
This sounds very confusing to me
Since we are validating the QR Code scan (the QR Code itself is already being tested in another step), we can just change it to something like:
Suggested change
| 1. Take a screenshot of the QR Code and open that screenshot in another device | |
| 1. Use the Mobile Wallet QR code scanner to read this screenshot | |
| 1. Pay the Payment Request using the same wallet used to generate it | |
| 1. Generate a payment request requesting a payment of 1 HTR from another device | |
| 1. Use the Mobile Wallet QR code scanner to read this screenshot | |
| 1. Pay the Payment Request, the transaction should be successful |
There was a problem hiding this comment.
It's a good idea. Changed the wording on bfa0c65.
tuliomir
force-pushed
the
docs/qr-code-scanner
branch
from
bf4e55f
to
ac71d21
Compare
tuliomir
force-pushed
the
docs/qr-code-scanner
branch
from
ac71d21
to
bfa0c65
Compare
pedroferreira1
approved these changes
Nov 16, 2023
andreabadesso
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we found some errors ( fixed by #384 and #386 ) that only happened during QR Code scanning. This procedure should also be on the main QA.
Acceptance Criteria
Security Checklist