fix: after serverless upgrade, GONE exceptions now throw an error #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes https://github.com/HathorNetwork/internal-issues/issues/275
In serverless v3,
ApiGatewayManagementApiClient
throws an error on failures, our code was not ready to handle them, so we were never handling GONE exceptions and old connections were stacking up in redis because of what is described in the issue above.Acceptance Criteria
sendMessageToClient
so that the SQS event is removed from the queue (and not retried)Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged