feat: allow sending alerts to another account #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislhl
requested review from
r4mmer and
andreabadesso
and removed request for
r4mmer
andreabadesso
previously approved these changes
Jul 10, 2024
tuliomir
previously approved these changes
Jul 10, 2024
| ALERT_MANAGER_REGION, | ||
| ALERT_MANAGER_TOPIC, | ||
| } = process.env; | ||
|
|
||
| const QUEUE_URL = `https://sqs.${ALERT_MANAGER_REGION}.amazonaws.com/${ACCOUNT_ID}/${ALERT_MANAGER_TOPIC}`; | ||
| const account_id = ALERT_MANAGER_ACCOUNT_ID || ACCOUNT_ID; |
There was a problem hiding this comment.
suggestion(non-breaking): Add a comment or another more visible documentation informing that, if the ALERT_MANAGER_ACCOUNT_ID is not informed, the wallet service's own ACCOUNT_ID will be used as default to reach the Alert Manager.
andreabadesso
approved these changes
Jul 11, 2024
tuliomir
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to send alerts from wallet-service Lambdas running in separate AWS sub-accounts
Acceptance Criteria
Deploy
nano-testnet) after mergingChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged