fix: parse release-candidate hathor-core versions #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislhl
requested review from
jansegre and
glevco
and removed request for
msbrogli
luislhl
force-pushed
the
fix/hathor-core-version
branch
from
0496219
to
ec114bc
Compare
glevco
approved these changes
Dec 8, 2023
jansegre
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
The lib should be able to parse hathor-core versions that belong to a release-candidate.
For instance,
0.58.0-rc.1.This PR makes sure it can parse all kinds of versions that follow the semver convention.
Additional change
I had to change the Github Actions job to use
pipinstead ofpipxto install Poetry, becausepipxwas apparently not using the right python version.This is a section of the run that should be done with Python 3.10, showing that it was using Python 3.12 somehow.
Because of this, things were breaking strangely. You can check https://github.com/HathorNetwork/python-hathorlib/actions/runs/7145463994 for the full logs.
Replacing
pipxwith justpipresolved this issue.