Skip to content

Commit

Permalink
chore: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tulio Miranda <tulio.mir@gmail.com>
  • Loading branch information
luislhl and tuliomir committed Oct 16, 2023
1 parent e6cc2be commit 20d55c5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions txstratum/healthcheck/healthcheck.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ async def get_health_check(self) -> ComponentHealthCheck:
health_check = ComponentHealthCheck(
component_name=self.COMPONENT_NAME,
component_type=ComponentType.FULLNODE,
# TODO: Ideally we should not use private fields. We'll fix this when fixing line 170
# TODO: Ideally we should not use private fields. We'll fix this when fixing line 74 below about getting the health information from the fullnode.
component_id=self.backend._base_url,
status=HealthCheckStatus.PASS,
time=datetime.utcnow().strftime("%Y-%m-%dT%H:%M:%SZ"),
Expand Down Expand Up @@ -96,12 +96,12 @@ class MiningHealthCheck(ComponentHealthCheckInterface):
If at least one of the 'tx_jobs' has a 'total_time' of more than 10 seconds, the health check
will be returned as 'warn'.
If some of the 'tx_jobs' has status different than 'done', the health check will be returned
If any of the 'tx_jobs' has status different than 'done', the health check will be returned
as 'fail'.
If there are no miners, the health check will be returned as 'fail'
If there are miners, but any of them has submitted a job in the last 1 hour, the health check
If there are miners, but none of them has submitted a job in the last 1 hour, the health check
will be returned as 'fail'
"""

Expand Down

0 comments on commit 20d55c5

Please sign in to comment.