feat(job): boost block weight when too low #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
force-pushed
the
feat/block-weight-boost
branch
from
f5b4dea
to
cfabd76
Compare
pedroferreira1
approved these changes
Dec 9, 2021
| # can do, and about what 2 GPUs on AWS can do. The boosting mechanism is to basically add WEIGHT_EXTRA_ADD capping | ||
| # it to MIN_WEIGHT_EXTRA (examples: weight=21.0 -> weight=25.0, weight=30.0 -> weight=34.0, weight=31.0 -> | ||
| # weight=34.0, weight=34.0 -> weight=34.0, weight=35.0 -> weight=35.0) | ||
| MIN_WEIGHT_EXTRA = 34.0 |
There was a problem hiding this comment.
I was a bit confused with this param name at first, to be honest. I was thinking about something like MAX_WEIGHT_TO_ADD_EXTRA. I'm okay to move with the current name as well
There was a problem hiding this comment.
I agree the name was chosen poorly. But your suggestion seems a bit convoluted, what about WEIGHT_BOOST_CAP, and WEIGHT_BOOST_BONUS.
luislhl
force-pushed
the
feat/block-weight-boost
branch
from
cfabd76
to
5b682a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance criteria: when the network weight is bellow a certain threshold, the mined blocks should have their weights increased (current proposal is to increase by a fixed amount up until the threshold).