Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portal-api does not react on SIGTERM, should shut down #48

Closed
DonMartin76 opened this issue Dec 18, 2016 · 1 comment
Closed

portal-api does not react on SIGTERM, should shut down #48

DonMartin76 opened this issue Dec 18, 2016 · 1 comment
Assignees
Milestone

Comments

@DonMartin76
Copy link
Member

DonMartin76 commented Dec 18, 2016

To make killing containers e.g. in Kubernetes, the portal-api should react to SIGTERM (and SIGINT) and shut down itself when it receives this signal.

This is especially needed when running in Kubernetes, as the scheduler first sends a SIGTERM, then, after 30s, a SIGKILL. If a container is to shut down, it should do so immediately (but gracefully) when it receives SIGTERM.

Side note: The other containers (mailer, chatbot, kong adapter) do.

@DonMartin76 DonMartin76 self-assigned this Dec 18, 2016
@DonMartin76 DonMartin76 added this to the 0.11.1 milestone Dec 18, 2016
@DonMartin76
Copy link
Member Author

Reason: portal-api uses a startup script which gets PID 1. Measure: Use https://github.com/Yelp/dumb-init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant