use other Captive Portal urls #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKULSHADY
pushed a commit
that referenced
this pull request
Nov 25, 2018
11-13 20:00:00.527 10645 10645 I crash_dump64: performing dump of process 1467 (target tid = 10124) 11-13 20:00:00.538 10645 10645 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** 11-13 20:00:00.539 10645 10645 F DEBUG : Build fingerprint: 'HONOR/BKL-L09/HWBKL:8.0.0/HUAWEIBKL-L09S/172(C432):user/release-keys' 11-13 20:00:00.539 10645 10645 F DEBUG : Revision: '0' 11-13 20:00:00.539 10645 10645 F DEBUG : ABI: 'arm64' 11-13 20:00:00.539 10645 10645 F DEBUG : pid: 1467, tid: 10124, name: Visualizer >>> com.android.systemui <<< 11-13 20:00:00.539 10645 10645 F DEBUG : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- 11-13 20:00:00.539 10645 10645 F DEBUG : Abort message: 'FORTIFY: pthread_mutex_lock called on a destroyed mutex (0x7c633df0f4)' 11-13 20:00:00.539 10645 10645 F DEBUG : x0 0000000000000000 x1 000000000000278c x2 0000000000000006 x3 0000000000000008 11-13 20:00:00.539 10645 10645 F DEBUG : x4 0000000000008080 x5 0000000000008080 x6 0000000000008080 x7 0000000000000038 11-13 20:00:00.539 10645 10645 F DEBUG : x8 0000000000000083 x9 40ef6d32d31c854a x10 0000000000000000 x11 fffffffc7ffffbdf 11-13 20:00:00.539 10645 10645 F DEBUG : x12 0000000000000001 x13 000000005beb1f30 x14 0005a1f49bc3a000 x15 0000112f9e154a12 11-13 20:00:00.539 10645 10645 F DEBUG : x16 0000007cffb6f2c8 x17 0000007cffaad0d0 x18 00000000fffbfffe x19 00000000000005bb 11-13 20:00:00.539 10645 10645 F DEBUG : x20 000000000000278c x21 0000007d000d96d0 x22 0000000000000001 x23 0000000000000035 11-13 20:00:00.539 10645 10645 F DEBUG : x24 0000007d000c6fc8 x25 0000007d000c7680 x26 0000007c52a14588 x27 0000000000000000 11-13 20:00:00.539 10645 10645 F DEBUG : x28 0000000000000005 x29 0000007c52a141a0 11-13 20:00:00.539 10645 10645 F DEBUG : sp 0000007c52a14160 lr 0000007cffaa1bfc pc 0000007cffaa1c24 11-13 20:00:00.564 10645 10645 F DEBUG : 11-13 20:00:00.564 10645 10645 F DEBUG : backtrace: 11-13 20:00:00.564 10645 10645 F DEBUG : #00 pc 0000000000021c24 /system/lib64/libc.so (abort+116) 11-13 20:00:00.564 10645 10645 F DEBUG : #1 pc 0000000000082f04 /system/lib64/libc.so (__fortify_fatal(char const*, ...)+120) 11-13 20:00:00.564 10645 10645 F DEBUG : #2 pc 0000000000082600 /system/lib64/libc.so (HandleUsingDestroyedMutex(pthread_mutex_t*, char const*)+52) 11-13 20:00:00.564 10645 10645 F DEBUG : #3 pc 00000000000824b4 /system/lib64/libc.so (pthread_mutex_lock+228) 11-13 20:00:00.564 10645 10645 F DEBUG : #4 pc 00000000000a8c54 /system/lib64/libmedia.so (android::Visualizer::periodicCapture()+56) 11-13 20:00:00.564 10645 10645 F DEBUG : #5 pc 00000000000a8aac /system/lib64/libmedia.so (android::Visualizer::CaptureThread::threadLoop()+88) 11-13 20:00:00.564 10645 10645 F DEBUG : #6 pc 000000000000f9d8 /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+280) 11-13 20:00:00.564 10645 10645 F DEBUG : #7 pc 00000000000b4980 /system/lib64/libandroid_runtime.so (android::AndroidRuntime::javaThreadShell(void*)+140) 11-13 20:00:00.564 10645 10645 F DEBUG : #8 pc 0000000000081938 /system/lib64/libc.so (__pthread_start(void*)+36) 11-13 20:00:00.564 10645 10645 F DEBUG : #9 pc 0000000000023478 /system/lib64/libc.so (__start_thread+68) Change-Id: Ic7f9788df8a38084c3b150eaa22d67f869085ca2
SKULSHADY
pushed a commit
that referenced
this pull request
Aug 26, 2023
There are two _different_ definitions of the NativeFamilyBuilder class, one in jni/FontFamily.cpp and the other in jni/fonts/FontFamily.cpp, violating the one-definition rule. Make them local by moving to an anonymous namespace. This is an issue in non-optimized builds where ~NativeFamilyBuilder isn't inlined, so the wrong destructor ends up being called: ``` (gdb) bt [...] #3 0x0000007292c44a8c in std::__1::vector<minikin::FontVariation, std::__1::allocator<minikin::FontVariation> >::~vector () #4 0x0000007292c44a54 in android::NativeFamilyBuilder::~NativeFamilyBuilder () #8 0x0000007292c64cec in android::FontFamily_Builder_build () ``` (note that the struct used by FontFamily_Builder_build() doesn't have the vector<minikin::FontVariation> field) Test: add "-O0" to hwui cflags and verify that system_server no longer hangs on startup Signed-off-by: Tomislav Novak <tnovak@meta.com> Change-Id: Ic071a7c00a9b2f632b6f56877f54c6a58eb38965 Signed-off-by: Anushek Prasal <anushekprasal@gmail.com>
SKULSHADY
pushed a commit
that referenced
this pull request
Oct 17, 2023
There are two _different_ definitions of the NativeFamilyBuilder class, one in jni/FontFamily.cpp and the other in jni/fonts/FontFamily.cpp, violating the one-definition rule. Make them local by moving to an anonymous namespace. This is an issue in non-optimized builds where ~NativeFamilyBuilder isn't inlined, so the wrong destructor ends up being called: ``` (gdb) bt [...] #3 0x0000007292c44a8c in std::__1::vector<minikin::FontVariation, std::__1::allocator<minikin::FontVariation> >::~vector () #4 0x0000007292c44a54 in android::NativeFamilyBuilder::~NativeFamilyBuilder () #8 0x0000007292c64cec in android::FontFamily_Builder_build () ``` (note that the struct used by FontFamily_Builder_build() doesn't have the vector<minikin::FontVariation> field) Test: add "-O0" to hwui cflags and verify that system_server no longer hangs on startup Signed-off-by: Tomislav Novak <tnovak@meta.com> Change-Id: Ic071a7c00a9b2f632b6f56877f54c6a58eb38965 Signed-off-by: Anushek Prasal <anushekprasal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.