Skip to content

Commit

Permalink
url: make URL.parse enumerable
Browse files Browse the repository at this point in the history
PR-URL: nodejs#53720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
panva authored and nodejs-github-bot committed Jul 6, 2024
1 parent da3afd9 commit 3ca05ff
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
6 changes: 6 additions & 0 deletions lib/internal/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -1167,6 +1167,12 @@ ObjectDefineProperties(URL, {
writable: true,
enumerable: true,
},
parse: {
__proto__: null,
configurable: true,
writable: true,
enumerable: true,
},
});

function installObjectURLMethods() {
Expand Down
8 changes: 0 additions & 8 deletions test/wpt/status/url.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@
]
}
},
"idlharness.any.js": {
"fail": {
"note": "TODO(@panva)",
"expected": [
"URL interface: operation parse(USVString, optional USVString)"
]
}
},
"url-setters-a-area.window.js": {
"skip": "already tested in url-setters.any.js"
},
Expand Down

0 comments on commit 3ca05ff

Please sign in to comment.