Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ignoreEmptyLines to FileLength and MethodLength checks #486

Merged

Conversation

AlexHaxe
Copy link
Member

@AlexHaxe AlexHaxe commented Nov 1, 2019

breaking removed countEmpty from MethodLength (use ignoreEmptyLines)
using token count for threshold in CodeSimilarity

*breaking* removed countEmpty from MethodLength (use ignoreEmptyLines)
using token count for threshold in CodeSimilarity
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #486 into dev will decrease coverage by 6.36%.
The diff coverage is 98.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #486      +/-   ##
==========================================
- Coverage   96.88%   90.52%   -6.37%     
==========================================
  Files         105      105              
  Lines        6716     6713       -3     
  Branches      912      913       +1     
==========================================
- Hits         6507     6077     -430     
- Misses        208      226      +18     
- Partials        1      410     +409
Impacted Files Coverage Δ
src/checkstyle/checks/size/FileLengthCheck.hx 96.66% <100%> (-3.34%) ⬇️
...style/checks/whitespace/ExtendedEmptyLinesCheck.hx 87.25% <100%> (-9.97%) ⬇️
...c/checkstyle/checks/whitespace/ListOfEmptyLines.hx 93.27% <100%> (-5.79%) ⬇️
...rc/checkstyle/checks/coding/CodeSimilarityCheck.hx 98.14% <100%> (-0.57%) ⬇️
src/checkstyle/checks/size/MethodLengthCheck.hx 97.77% <96.42%> (+35.45%) ⬆️
...eckstyle/checks/whitespace/WhitespaceAfterCheck.hx 50.6% <0%> (-49.4%) ⬇️
.../checkstyle/checks/whitespace/OperatorWrapCheck.hx 60.21% <0%> (-39.79%) ⬇️
src/checkstyle/utils/ArrayUtils.hx 16.66% <0%> (-33.34%) ⬇️
src/checkstyle/checks/literal/ERegLiteralCheck.hx 83.33% <0%> (-16.67%) ⬇️
src/checkstyle/utils/StringUtils.hx 83.33% <0%> (-16.67%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca55ec...f925a22. Read the comment docs.

@AlexHaxe AlexHaxe merged commit 20e5435 into HaxeCheckstyle:dev Nov 1, 2019
@AlexHaxe AlexHaxe deleted the file_length_ignore_empty_lines branch November 1, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant