-
Notifications
You must be signed in to change notification settings - Fork 433
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update URL parsing logic (again). (#1996)
Added a new FlxStringUtil.getHost function to handle the (nearly) proper URL parsing. Updated FlxStringUtil.getDomain to use this new function. !Breaking change: getDomain now returns the empty string ("") upon failure. (Previous behavior was to return "local".) Cleaned up logic in FlxBasePreloader.isHostUrlAllowed. Removed conditional definition of FlxBasePreloader.LOCAL. (Its value is no longer target-specific.) Added new unit tests. Refactor unit tests to allow code reuse.
- Loading branch information
1 parent
ae716ae
commit 5dfc1e8
Showing
3 changed files
with
97 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters