Hscript console, closes #1156

[MSGhero]

The console itself works fine now, but now I need some confirmation that these changes are ok. There are some breaking changes now.

[larsiusprime]

neato

[MSGhero]

I'm mainly done now, but yeah it's a breaking change. Since hscript deals with objects directly instead of strings, I removed all the parsing code and string parameters from functions. ie: switchState command now straight up takes a new state: switchState(new TestState()).

[MSGhero]

Pausing and TAB don't work on neko, but they probably never did. Didn't test html5 or -Dnext.

[MSGhero]

The travis script and unit tests seem ok on my computer, and the build does install hscript. Why can't it find hscript.Expr?

[Gama11]

As is, every flixel project that doesn't include hscript in the xml manually won't compile - would be better to have that in the include.xml.

In theory it would be nice to only include it if it's installed (and only have the console be usable in that case), but I'm not sure if there's a way to do that with the project xml format...

[MSGhero]

I added it to include.xml, but would it go somewhere besides the setup block? Should I wrap all console code in #if hscript?

[Gama11]

setup is only used for lime setup flixel. If you actually want to include the haxelib during compilation, you need the regular <haxelib name="hscript" /> like the include.xml does with openfl.

[MSGhero]

Ugh ok. I see what you mean now about always including it. I guess it would always be included for release builds too even when the debugger flxdef is off.

[MSGhero]

The unit tests look fine, but it's still breaking coverage on the import hscript.Expr

[Gama11]

The unit tests use a .hxml file for flash.

https://github.com/HaxeFlixel/flixel/blob/dev/tests/unit/test.hxml

[MSGhero]

I'm never adding an external lib to flixel again.

[MSGhero]

Oh hey, dev cpp is working again. Haxe recently fixed the multiple inheritance issue which was preventing flixel-ui from compiling.

[gamedevsam]

This change looks great! Has anyone been able to test this functionality?

[MSGhero]

Me lol. Do you need a rundown of the changes or are you making sure it works for other people?

[gamedevsam]

I was mostly wondering if there was someone in the community that opposes this change or has something to say before I merge it in. @HaxeFlixel/owners any opposition or can I merge this?

[Beeblerox]

i haven't checked this pull request, but i don't mind replacing current functionality with hscript as far as it works

[MSGhero]

FlxInterp? lol

[MSGhero]

I'm not 100% sure if the Watch tab still works all the time, but the watch console command does work.

I'm also not sure why the Event.RENDER bit was in there, maybe a workaround for an old openfl issue?

[Gama11]

The ability to run arbitrary Haxe code from the console is pretty amazing. :)

Also:

202 additions and 809 deletions

👍

Not too mention, seems like it's not as crashy on neko anymore.

[MSGhero]

In the original issue, you said that it'd be cool if we could #if hscript to display an error message if not. Is that possible in retrospect, or is hscript a dependency for this lib now?

[Gama11]

It's not possible unless we remove the <haxelib name="hscript" /> from the include.xml, so the user would have to add that manually to his Project.xml (which I'm not a fan of), since there's no way to tell openfl to "include this lib if it's there". If a haxelib isn't there, it errors.

[Gama11]

We could try using Compiler.addClassPath() and check the output of haxelib path hscript in the initialization macro. Unfortunately there's no Compiler.addHaxelib() (HaxeFoundation/haxe#4678).
Not sure if that would confuse OpenFL in some way.