call members' kill/revive when called on sprite groups #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
added a commit
that referenced
this pull request
Jan 26, 2022
* Enable workflow_dispatch * Fixing little error for android build (#2407) * Explain FlxG singletons in input util docs (#2411) * Mention color in docs for FlxBitmapFont.fromMonospace (#2412) This makes it a little more clear that if you're loading a FlxBitmapFont from a monospace font file that you wish to change the color of, ensure the pixels are white. This allows the textColor property to work as expected. If the pixels happen to be black, the textColor changes won't be visible. * redraw sprite before `updateHitbox()`. fixes #2413 (#2417) * Remove references to FlxObject direction flag constants (#2424) * fix: image showcase link (#2438) * Fixed spelling in comment in FlxBasePreloader (#2447) * Update documentation on scale modes. (#2455) * Update license link (#2464) * remove redundant modifier (#2467) * Fix CI * Add FlxAnimationController.getNamesList() to get the current list of animation names (#2473) * Add the list thing * Oops, beta description * Kinda a fix? * Experimental stuff with setting new names lol * Adds a more safe option in case you don't complete the entire thing * remove the variable and add the functions * change some minor stuff * remove the last _list things * Update FlxAnimationController.hx * Idk if it works but maybe the checks are failing cos of that? * Add a nicer code and description stuff * add tests, and small corrections * Add the rename test on FlxAnimationControllertest Co-authored-by: George FunBook <gkurelic@gmail.com> * fix typo in unit tests * Add getRotatedRectBounds helpers (#2298) * `FlxRect.getRotatedBounds` * `FlxObject.getRotatedBounds` * `FlxSprite.getRotatedBounds` - override * `FlxSprite.getScreenBounds` - similar to `FlxSprite.getScreenPosition` * `FlxSpriteUtil.cameraWrap` - similar to `FlxSpriteUtil.screenWrap` but uses FlxDirectionFlags instead of 4 booleans * `FlxSpriteUtil.cameraBounds` - similar to `FlxSpriteUtil.cameraWrap` * `FlxCamera.getViewRect` - helper for `FlxSpriteUtil.cameraWrap` and `cameraBound` * `FlxCamera.containsRect`- helper for `FlxSpriteUtil.cameraWrap` and `cameraBound` * `FlxCollision.pixelPerfectCheck` - uses getScreenBounds to reduce the number of pixel checks, honors FlxSprite's scale * `FlxSprite.isOnScreen` - uses getScreenBounds for more accuracy * `FlxCamera.containsPoint` - calls putWeak * ignore failing test for now * sceenCenter Readibility (#2441) * add screenCenter test * improve readability of screenCenter * add check with no parameters * inline screenCenter * update FlxState comment on constructor * Prevent hashlink segfaults on linux (#2487) * change integers used for ANY and NONE FlxKey <REVERTED> * add FlxKey tests for ANY/NONE * remove switch causing seg faults Co-authored-by: jf <j@b.f> Co-authored-by: George FunBook <gkurelic@gmail.com> * call members' kill/revive when called on sprite groups (#2423) * call members' kill/revive when called on sprite groups * make sure kill/revive is NOT called when not needed * fix spriteGroup.reset() * minimize setters * add resetTest * remove haxe4 compile conditions (#2489) * Release 4.11.0 (#2490) * add release notes * seg fault bugfix * FlxSpriteGroup kill/revive * change haxelib * wording * change date Co-authored-by: Jens Fischer <jensfischer95@gmail.com> Co-authored-by: Gliar <public.ms513@gmail.com> Co-authored-by: Brett Chalupa <brettchalupa@gmail.com> Co-authored-by: Julian Holfeld <julianholfeld@student.uni-kassel.de> Co-authored-by: RafPlayz69YT <79861112+brosomethingwrongwithyothing@users.noreply.github.com> Co-authored-by: Eric Myllyoja <ericmyllyoja@gmail.com> Co-authored-by: MrClogsworthYT <85831572+MrClogsworthYT@users.noreply.github.com> Co-authored-by: MrCheemsAndFriends <84867412+Cheemsandfriends@users.noreply.github.com> Co-authored-by: jobf <jamesobfisher@gmail.com> Co-authored-by: jf <j@b.f>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2306
FlxGroups weren't calling kill() and revive on it's members, but it appeared as though it was, because it was setting alive and exists on each of them individually.
I also changed reset(). Before it would move everything over uniformly, and then reset every sprite to the same x,y. Now it resets everything to a new uniformly moved position.