Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and cleanup in small areas #2755

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Simplify and cleanup in small areas #2755

merged 3 commits into from
Apr 5, 2023

Commits on Mar 14, 2023

  1. remove redundancy in FlxAnimation.play() 

    `finished` must be false in order for this to run which sets it to false again.
    @CrazyInfin8
    CrazyInfin8 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    fc62b4c View commit details
    Browse the repository at this point in the history

  2. remove redundancy in FlxColor.get_hue() 

    `hueRad` calculated this value already so, for readability, we don't need to put the whole formula again.
    @CrazyInfin8
    CrazyInfin8 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f21bee0 View commit details
    Browse the repository at this point in the history

  3. Saturation isn't used in FlxColor.setHSChromaMatch()

    @CrazyInfin8
    CrazyInfin8 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    1f853fb View commit details
    Browse the repository at this point in the history