Untie FlxSoundTray animation speed from framerate, and make it much smoother #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
requested changes
Oct 3, 2023
There was a problem hiding this comment.
the comment changes are good, removing * 2 does make it more smooth, these changes are fine but revert FlxG.elapsed to (MS / 1000)
If you believe that I'm wrong and this does make the sound tray less frame rate dependent, then I'll need some evidence, because I believe using FlxG.elapsed changes nothing, at best, and at worst, it does the opposite of what you claim, it actually makes the hide animation take more or less time depending on any performance lag
Co-authored-by: George Kurelic <Gkurelic@gmail.com>
|
Done. |
Geokureli
approved these changes
Oct 4, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that higher framerates make the FlxSoundTray go-away animation go way too fast, and that it's very janky in general. This really bothered me, so I decided to make a quick fix. This also updates some very old comments to fit the standard more.