Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove health field and hurt function in FlxObject #3065

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

moxie-coder
Copy link
Contributor

I couldn't find any duplicates to this, but if you wanna correct me on this Geokureli, you can, but this just seems pretty redundant now, this was probably kept for backwards compatibility or legacy reasons, but it seems pretty useless now since you could just extend FlxObject to readd it or something similar like that.

There are many other ways of doing it though, so I feel like this really isn't needed now, especially since it was last updated around 11 years ago and I don't think this is really used a lot, or just not at all in contrast to now

@DetectiveBaldi
Copy link
Contributor

if this were to go through, it would probably be best to deprecate these for now, and then remove them entirely in flixel 6.0.0
overall i agree with this

@Geokureli
Copy link
Member

Geokureli commented Mar 10, 2024

yeah we can't just remove fields because it'll break everyone's project. first deprecate it, and then we'll talk about a good way to remove this without adding more friction to 6.0.0, which already worries me

Edit: @moxie-coder how is it "redundant"?

@Geokureli Geokureli merged commit 1111e9c into HaxeFlixel:dev Mar 10, 2024
12 of 16 checks passed
@Geokureli Geokureli added this to the 5.7.0 milestone Mar 11, 2024
@moxie-coder
Copy link
Contributor Author

yeah we can't just remove fields because it'll break everyone's project. first deprecate it, and then we'll talk about a good way to remove this without adding more friction to 6.0.0, which already worries me

Edit: @moxie-coder how is it "redundant"?

because you could just add it via extending the class, or making your own class too, there’s plenty of ways to add it in, and this felt like a leftover from the early days

@moxie-coder moxie-coder deleted the patch-1 branch March 11, 2024 10:25
@Geokureli
Copy link
Member

because you could just add it via extending the class, or making your own class too, there’s plenty of ways to add it in, and this felt like a leftover from the early days

Odd semantics, but not really "redundant", we are removing a feature so that it can be added back differently, if needed. I was also thrown off by "now redundant" as if something recently changed with this

@Geokureli Geokureli changed the title Remove (now redundant) health variable and function in FlxObject Remove health variable and function in FlxObject Mar 11, 2024
@Geokureli Geokureli changed the title Remove health variable and function in FlxObject Remove health field and hurt function in FlxObject Mar 11, 2024
Geokureli added a commit that referenced this pull request Mar 11, 2024
@moxie-coder
Copy link
Contributor Author

because you could just add it via extending the class, or making your own class too, there’s plenty of ways to add it in, and this felt like a leftover from the early days

Odd semantics, but not really "redundant", we are removing a feature so that it can be added back differently, if needed. I was also thrown off by "now redundant" as if something recently changed with this

sorry, I probably could’ve worded it better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants