-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove health field and hurt function in FlxObject #3065
Conversation
if this were to go through, it would probably be best to deprecate these for now, and then remove them entirely in flixel 6.0.0 |
This reverts commit 9d7b2f1.
yeah we can't just remove fields because it'll break everyone's project. first deprecate it, and then we'll talk about a good way to remove this without adding more friction to 6.0.0, which already worries me Edit: @moxie-coder how is it "redundant"? |
because you could just add it via extending the class, or making your own class too, there’s plenty of ways to add it in, and this felt like a leftover from the early days |
Odd semantics, but not really "redundant", we are removing a feature so that it can be added back differently, if needed. I was also thrown off by "now redundant" as if something recently changed with this |
sorry, I probably could’ve worded it better |
I couldn't find any duplicates to this, but if you wanna correct me on this Geokureli, you can, but this just seems pretty redundant now, this was probably kept for backwards compatibility or legacy reasons, but it seems pretty useless now since you could just extend FlxObject to readd it or something similar like that.
There are many other ways of doing it though, so I feel like this really isn't needed now, especially since it was last updated around 11 years ago and I don't think this is really used a lot, or just not at all in contrast to now