Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpp.Int64 <-> haxe.Int64 roundtrip #10101

Merged
merged 6 commits into from Feb 3, 2021
Merged

Fix cpp.Int64 <-> haxe.Int64 roundtrip #10101

merged 6 commits into from Feb 3, 2021

Conversation

haxiomic
Copy link
Member

@haxiomic haxiomic commented Feb 2, 2021 •
edited

Changes

  • Added private auto-casts for haxe.Int64: @:to toInt64(): cpp.Int64 and @:from ofInt64(x: cpp.Int64)
  • Removed unused get() method from ___Int64 as it cannot be used without @:structAccess anyway
  • Added regression test for roundtrip

closes #10100

@RealyUniqueName RealyUniqueName merged commit dc1fbac into HaxeFoundation:development Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpp.Int64 -> haxe.Int64 silently converts to Int32
2 participants
@haxiomic @RealyUniqueName