Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests for 4.3 Hotfix (part 2) #11201

Closed
13 tasks done
Simn opened this issue May 5, 2023 · 11 comments
Closed
13 tasks done

Pull requests for 4.3 Hotfix (part 2) #11201

Simn opened this issue May 5, 2023 · 11 comments
Assignees

Comments

@Simn Simn added this to the 4.3 Hotfix milestone May 5, 2023
@RblSb
Copy link
Member

RblSb commented May 5, 2023

Want to request #11114 in fix release
Second part of efield fix: #11206

@kLabz
Copy link
Contributor

kLabz commented May 7, 2023

  • I'd like to add 34afe73 too so that people can silence @:enum abstract deprecation warnings with addGlobalMetadata.
  • Also ea57ab1 to be able to target those warnings

@tobil4sk
Copy link
Member

tobil4sk commented May 7, 2023

#11192 fixes #11005 which technically isn't a 4.3 regression, but it became worse because in 4.3 any code with a macro that uses haxe.macro.Compiler breaks when using -D no-inline.

So it may be nice to have in a 4.3 bugfix?

@kLabz
Copy link
Contributor

kLabz commented May 7, 2023

Seems fine to me

@giuppe
Copy link

giuppe commented Jun 27, 2023

Any chance that #11249 will be added to the next hotfix?

@kLabz
Copy link
Contributor

kLabz commented Jun 27, 2023

Hmm yeah, but I should make it work properly first.
Will look into that later this week or early next week.

@RblSb
Copy link
Member

RblSb commented Sep 1, 2023

It is not too late for #11252, #11294?
Currently error on float ?? 0 hurts.

@kLabz
Copy link
Contributor

kLabz commented Sep 1, 2023

It kinda is too late for 4.3.2 :/

@Simn
Copy link
Member Author

Simn commented Sep 1, 2023

#11252 at least seems kind of important though...

@RblSb
Copy link
Member

RblSb commented Sep 8, 2023

62bdf35
44c9abd

@kLabz
Copy link
Contributor

kLabz commented Sep 8, 2023

Thanks, will be tracked in #11306

@kLabz kLabz closed this as completed Sep 8, 2023
@kLabz kLabz removed this from the 4.3 Hotfix milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants