Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extra field error range #11335

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

RblSb
Copy link
Member

@RblSb RblSb commented Oct 18, 2023

Closes #11334

@kLabz
Copy link
Contributor

kLabz commented Oct 18, 2023

I thought we usually covered both field name + field value for this kind of errors?

@RblSb
Copy link
Member Author

RblSb commented Oct 18, 2023

I recently made duplicate field errors also like this.
Not sure if field: value range is better here, it will simplify field removal on ide side (probably not much with tokentree?), but it will make optional field name typos more verbose.

@Simn
Copy link
Member

Simn commented Oct 18, 2023

I think just the name is better because the value itself could also be multiple lines and all that.

@Simn Simn merged commit c2479a0 into HaxeFoundation:development Oct 18, 2023
61 checks passed
@RblSb RblSb deleted the better_extra_fields branch October 19, 2023 01:20
kLabz pushed a commit that referenced this pull request Nov 14, 2023
* Improve extra field error range

* update range

* fail
0b1kn00b pushed a commit to 0b1kn00b/haxe that referenced this pull request Jan 25, 2024
* Improve extra field error range

* update range

* fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Has extra field error range is too big
3 participants