Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field generation regression #11472

Open
RblSb opened this issue Jan 8, 2024 · 2 comments
Open

Missing field generation regression #11472

RblSb opened this issue Jan 8, 2024 · 2 comments

Comments

@RblSb
Copy link
Member

RblSb commented Jan 8, 2024

Commit 52bb475 breaks missing field generation in vshaxe:

class Main {
	static function main() {
		foo = 0;
	}
}

Generation before: static var foo:Int;
Now: static var foo:?; (monomorph)

@RblSb
Copy link
Member Author

RblSb commented Jan 8, 2024

Little more context: MissingFieldDiagnostics now returns type : {kind : TMono} instead of abstract around Int.
Can be viewed with trace(fields) around here https://github.com/vshaxe/haxe-language-server/blob/0f3418b7725d48e053c53b805b51f58ce372378f/src/haxeLanguageServer/features/haxe/codeAction/diagnostics/MissingFieldsActions.hx#L130

@RblSb
Copy link
Member Author

RblSb commented May 3, 2024

I hope this regression will be fixed for the next release, at the moment this useful ide feature is broken in dev builds. Would like to migrate to dev since compilation server is at sad state for me in stable release with many fake display recursive inline errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant