[hl] hlopt rework try-catch control flow #11581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now good on my end. Will leave it to @ncannasse to check the hlopt changes themselves. |
|
@ncannasse told me to be autonomous (i.e. check by my self with our code base and merge). I checked and I'm ok with the code. I just made a little adjustment for debug, I'll merge when CI green. |
Simn
reviewed
Feb 26, 2024
|
@Simn I'd like to include this in 4.3.4 if that's ok |
|
Should be good! |
kLabz
pushed a commit
that referenced
this pull request
Mar 4, 2024
kLabz
pushed a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11466 and #9174 .