Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add hxBitcoin library for third-party CI tests #3692

Closed
nadako opened this issue Dec 16, 2014 · 16 comments
Closed

[tests] add hxBitcoin library for third-party CI tests #3692

nadako opened this issue Dec 16, 2014 · 16 comments
Assignees
Milestone

Comments

@nadako
Copy link
Member

nadako commented Dec 16, 2014

This new cryptography/cryptocurrency library https://github.com/cbatson/hxBitcoin seems to have extensive tests that IMO we should add to our CI tests as it would help preventing regressions wrt optimizations like const propagation and whatnot.

@Simn
Copy link
Member

Simn commented Dec 16, 2014

Why is this not a pull request? ;)

@nadako
Copy link
Member Author

nadako commented Dec 16, 2014

i was hoping @andyli could somehow add this quickly before I start looking into it :)

@Simn
Copy link
Member

Simn commented Dec 16, 2014

Is there still no way to make travis trigger third party builds?

@waneck
Copy link
Member

waneck commented Dec 16, 2014

I could configure the build servers to trigger a travis build. I'd need a travis token and I'm not sure how this will actually work - will we trigger the travis build at hxBitcoin? Or will we trigger the travis build on a fork of it?

@waneck
Copy link
Member

waneck commented Dec 16, 2014

We could maybe setup a (low security) github user which will fork all projects we want to trigger a build. This way the build servers can automatically pull from upstream and trigger the travis build on the latest Haxe.

@andyli
Copy link
Member

andyli commented Dec 16, 2014

I would suggest hxBitcoin (and other 3rd party libs) to have its own travis build because that scales better with increasing number of libs. If we use our HaxeFoundation acc (or a dedicated acc), the number of concurrent builds is very limited.

@waneck
Copy link
Member

waneck commented Dec 16, 2014

I wouldn't mind the builds being slow if we used a dedicated account for that

@Simn
Copy link
Member

Simn commented Dec 16, 2014

The problem with them having their own travis is still that we cannot ping it to run. They need their own travis too though because otherwise we end up in a situation like with the OpenFL tests where they kept breaking their stuff and we were the only ones to notice.

@waneck
Copy link
Member

waneck commented Dec 16, 2014

We can ping them to run again with the travis api. I can trigger a travis
rebuild from the build servers. Also the nice thing about this is that we
don't have to rebuild haxe from scratch - we can use the freshly built
binary
We can also avoid getting pinged when a lib breaks their own stuff by using
a fork and only merging from upstream occasionally - perhaps with a pull
request

@Simn
Copy link
Member

Simn commented Dec 16, 2014

Ah, if that's possible now then it's a good solution.

@Simn
Copy link
Member

Simn commented Dec 20, 2014

"Your test run exceeded 50 minutes."

Oh dear... :)

@cbatson
Copy link
Contributor

cbatson commented Dec 21, 2014

Yeah. :-) The tests run really slow on Neko on that system for some reason. I haven't timed it, but I don't think it takes that long on my aging local PC.

And that was just one of several unanticipated adventures along the way. Here's another fun one you'll appreciate: https://chuckbatson.wordpress.com/2014/12/20/gcc-compiler-bug-broke-my-haxe-code/

It is done, at least for Linux + hxcpp. Hope to add more targets & platforms to the automated process later. (I run them manually on all platforms before a release.)

@Simn
Copy link
Member

Simn commented Dec 21, 2014

I see that you're running your tests with Haxe stable. That doesn't really help us much, hmm...

@cbatson
Copy link
Contributor

cbatson commented Dec 22, 2014

I'll add a variation that runs against development Haxe. Is cloning from git and building the best way to do that, or is there another preferred way?

@cbatson
Copy link
Contributor

cbatson commented Jan 5, 2015

Please take a look now; I have a couple jobs in the Travis matrix using Haxe from git.

Will this work for your needs?

@Simn Simn added this to the 3.3 milestone Feb 22, 2015
@Simn Simn modified the milestones: 3.3.0-rc1, 4.0 Feb 23, 2016
@Simn
Copy link
Member

Simn commented Apr 4, 2016

This fell under the radar completely so we might as well close it now. Sorry about that.

@Simn Simn closed this as completed Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants