Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haxe 4: missing error handling for Context.getTypedExpr(null) #7007

Closed
kLabz opened this issue May 8, 2018 · 0 comments
Closed

Haxe 4: missing error handling for Context.getTypedExpr(null) #7007

kLabz opened this issue May 8, 2018 · 0 comments
Assignees
@Simn
Milestone
Release 4.0

Comments

@kLabz
Copy link
Contributor

kLabz commented May 8, 2018 •
edited

###Edit

Found the actual issue, it was not really related to the things I pointed to at first.

To summarize: in Haxe 4, Context.getTypedExpr(null) fails with MacroApi.Invalid_expr instead of throwing 'Invalid input value'.

See http://try-haxe.mrcdk.com/#1979B

I think this error should be handled with a proper error message or by throwing an exception. Haxe 3.4.X handled this by throwing a 'Invalid input value' exception.
@kLabz kLabz changed the title Conflict between Context.getType() and using haxe.macro.Tools Haxe 4: errors with Context.getType() May 8, 2018
@kLabz kLabz changed the title Haxe 4: errors with Context.getType() Haxe 4: missing error handling for Context.getTypedExpr(null) May 8, 2018
@kLabz kLabz mentioned this issue May 8, 2018
Merged
@Simn Simn self-assigned this May 13, 2018
@Simn Simn added this to the Release 4.0 milestone May 13, 2018
@Simn Simn closed this as completed in dfe1795 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simn Simn

Labels
None yet
Projects
None yet
Milestone
Release 4.0
Development

No branches or pull requests
2 participants
@Simn @kLabz