Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicodeString #8298

Conversation

RealyUniqueName
Copy link
Member

@RealyUniqueName RealyUniqueName commented May 17, 2019

Closes #8175

  • Introduces UnicodeString which consistently handles all unicode code points across all targets.
  • Removes haxe.Utf8
  • Adds neko.Utf8

This implementation is not locale-aware, which means that for some languages toUpperCase/toLowerCase may work incorrectly.
E.g. for turkish "ıi".toUpperCase() becomes "II instead of "Iİ".

@ncannasse ncannasse requested a review from Aurel300 May 17, 2019 21:47
@RealyUniqueName
Copy link
Member Author

RealyUniqueName commented May 17, 2019

Cpp failure is unrelated.

@ncannasse hl fails on these lines (other targets pass):

s > s2;
s >= s2;
s2 < s;
s2 <= s;

wheres s is UnicodeString and s2 is String.

@RealyUniqueName
Copy link
Member Author

@ncannasse hl fails on these lines (other targets pass):

That's not related to UnicodeString: HaxeFoundation/hashlink#250

@RealyUniqueName
Copy link
Member Author

@hughsando The same issue with hxcpp: HaxeFoundation/hxcpp#797

std/UnicodeString.hx Show resolved Hide resolved
tests/unit/src/unit/UnitBuilder.hx Show resolved Hide resolved
tests/unit/src/unitstd/UnicodeString.unit.hx Outdated Show resolved Hide resolved
@RealyUniqueName RealyUniqueName merged commit b49724d into HaxeFoundation:development May 30, 2019
Gama11 added a commit to vshaxe/haxe-TmLanguage that referenced this pull request Jun 1, 2019
RealyUniqueName added a commit that referenced this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

haxe.Utf8
2 participants