Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict @:allow(some.pack) to types located in that package only #8306

Merged
merged 1 commit into from May 19, 2019
Merged

Restrict @:allow(some.pack) to types located in that package only #8306

merged 1 commit into from May 19, 2019

Conversation

RealyUniqueName
Copy link
Member

And don't allow access to their descendandts in other packages.

Fixes #6525

@RealyUniqueName RealyUniqueName requested a review from Simn May 19, 2019 16:43
@RealyUniqueName RealyUniqueName added this to the Release 4.0 milestone May 19, 2019
Simn
Simn approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@Simn Simn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have PTSD from this function so if you say that this works I'll just believe you. :P

@RealyUniqueName
Copy link
Member Author

I've spent a lot of time building execution flow graph in my brain :)

@RealyUniqueName
Copy link
Member Author

cpp & php failures are not related

@RealyUniqueName RealyUniqueName merged commit a05769a into HaxeFoundation:development May 19, 2019
@skial skial mentioned this pull request May 20, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simn Simn Simn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.0
Development

Successfully merging this pull request may close these issues.

@:allow should not be inherited
2 participants
@RealyUniqueName @Simn