Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Initialization status #8666

Closed
Simn opened this issue Aug 20, 2019 · 0 comments
Closed

[server] Initialization status #8666

Simn opened this issue Aug 20, 2019 · 0 comments

Comments

@Simn
Copy link
Member

Simn commented Aug 20, 2019

The compilation server currently has a single initialized flag which governs the class path exploration. This works fine for single contexts, but misses information if there are multiple contexts involved.

As an example, starting the server with a Hello World program and then adding -lib flixel to the build will cause completion requests to miss the flixel packages and types.

We should instead track initialization status per-signature.


A related problem is the change of class paths without changing the signature. This is a rare case which only occurs by adding or removing explicit -cp arguments (because -lib comes with -D which changes signature). We already detect changed class paths, so this is a matter of unsetting the initialization status.

@Simn Simn added this to the Release 4.0 milestone Aug 20, 2019
@Simn Simn self-assigned this Aug 20, 2019
@Simn Simn closed this as completed in 9f0489a Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant