-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js] getComputedStyle argument type #9085
Comments
Yeah. According to MDN |
Follows on from the discussion on DOMElement / HTMLElement -> Element differences and remapping I think the original remap of Element -> HTMLElement was done because many methods technically return Elements but practically return HTMLElements It would be great to see if we can straighten this out for 4.1. My current thinking on how to improve the externs going forward is to use the TypeScript extern generator as a base for a rewrite, since TS put a lot of effort into getting the html externs perfect |
An I always thought that this weird remap was mainly done because of the My suggestion would be:
|
If it would go down well with the community I'd love to do as you suggest @mockey and rebuild the externs without any renaming. I like your suggestion of moving to Big change of course because so many projects rely on these but I guess we can always add To ball-park, the timeline for something like this is out at around 6 months because I'd want to do it as part of the html-externs rewrite |
I guess
js.html.Window.getCompiutedStyle
should better useDOMElement
(a.k.a. Element) instead ofElement
(a.k.a .HTMLElement) for its argument type, shouldn't it?The text was updated successfully, but these errors were encountered: