[WIP] Working with svgs + new geometry options #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now directly working with the SVGs, rather than downloading them as PNGs. This allows resizing to be lossless. I've also added new options --shield_scale and --shield_geometry. TODOs: * Figure out why 90.5 is the density factor rather than 72 or 96 * Figure out why the composite is losing the alpha from the shield * Figure out why Net:HTTP is choking on the SVG (why I used curb)
|
Hey, |
HazAT
requested changes
Feb 16, 2017
|
|
||
| if icon.width > current_shield.width && !shield_no_resize | ||
| current_shield.resize "#{icon.width}x#{icon.height}<" | ||
| svg_shield = MiniMagick::Image.open(shield.path) |
| file.write(open(url).read) | ||
| file.close | ||
| end | ||
| Curl::Easy.download(url, file_name) |
There was a problem hiding this comment.
This would be ok ... but I am not sure if the download fails the above rescue OpenURI::HTTPError => error will catch the error then ... please check that
|
|
||
| png_shield = MiniMagick::Image.open(new_path) | ||
|
|
||
| result = composite(result, png_shield, alpha_channel, shield_gravity || "north", shield_geometry) |
There was a problem hiding this comment.
You could remove the png_shield and directly pass MiniMagick::Image.open(new_path)
|
@jamesdaniels I had some time and merged it locally, thx again for your PR 🥇 |
|
Thanks and glad it made it in! Sorry didn't have time to address your feedback myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Daniel, I wanted to open a PR for this work in progress change I have that manipulates SVGs in badge. This leads to better quality badges when resized and makes an especially big difference on Android.
Just wanted to start a conversation around this change.
Curb was added as a dependency due to a problem in my local environment, that keeps
net/httpfrom requesting from shield.io. I haven't figured out what this is yet. I'll see about at least separating this from the PR.rsvg-convertis now a CLI dependency, as even when compiled with SVG support magick still has compatibility issues (inexplicable black badges on Travis for example). I need to add some error handling here.I added new options,
shield_scaleandshield_geometrywhich allow you to resize the shield and move it around respectively.Example usage:
bundle exec badge --glob "/../app/src/main/res/**/ic_launcher.png" --shield $SHIELD --no_badge --shield_geometry "+0+25%" --shield_scale 0.75Let me know what you think!