Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'fastlane' a development_dependency in badge.gemspec #98

Closed
wants to merge 1 commit into from

Conversation

liamnichols
Copy link

Resolved #97

Thanks for all the prior work that has gone into this library, we've used it for a long time now and it's ace 🙏🙏🙏

As per my description in #97, this change marks the fastlane gem as a development dependency rather than a runtime dependency so this should break the cycle that people may be running into.

@liamnichols
Copy link
Author

Note that it turns out the issue that I was originally referring to was in fact caused by fastlane/fastlane/issues/16130, but I was led to believe that it was related to fastlane-plugin-badge since it was depending on fastlane..

I think (unless I've misunderstood something) that its still good practice to keep this just as a development dependency but please do correct me if I'm wrong 🙏

@HazAT
Copy link
Owner

HazAT commented Feb 7, 2022

I won't merge this, I know it's ideal but this plugin was designed to be used with fastlane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'fastlane' as a runtime dependency in badge.gemspec
2 participants